Javascript null check

Javascript null check - or is it?

I'm back to the blog! After so many years it seems that the fire is still there and I felt the need to share little something. Without further rumble, let's jump into one of the situations that I find a lot on the job: checking for null on Javascript.
Here is the kind of code that has caused me much pain:

The intent of this is to only do stuff if shipType has a value. I always try to avoid this piece of code and use something more explicit, even when I know there is no problem with the code now.

But why so picky? Checking for null this way has a few problems. Here is a snippet demonstrating:

Notice how, if the value of shipType is a number and is 0, it is never printed. This kind of bug becomes very common because C# uses integers by default as an underlying type for enums, and 0 is the default value for it.

The reason is that null is a falsy value - if you force it to be evaluated as a boolean it will return false. Falsy values are what allows you to write that syntax in the first place. Well, guess what? 0 is also a falsy value! So is the empty string value "".

So, next time you want to check for null, do so explicitly to avoid these kinds of bugs.

Comments

Why is the Single Responsability Principle important?

The Single Responsability Principle is one of the five S.O.L.I.D. principles in which i base my everyday programming. It tells us how a method or class should have only one responsability. Not a long time ago i was designing a reporting service with my colleague Nuno for an application module we were redoing and we had a method that was responsible for being both the factory method of a popup view and showing it to the user. You can see where this is going now... I figured out it would not be a that bad violation of the principle, so we moved on with this design. The method was called something like "ShowPrintPopup" and it took an IReport as an argument. All this was fine, but then we got to a point where we needed to have a permissions system to say if the user was able to export the report to Excel, Word, PDF, etc... The problem was the print popup would need to know beforehand if it would allow the user to export the report or not, so that it could show it's UI a...

From crappy to happy - refactoring untestable code - an introduction

I started testing my code automatically a couple of years in after starting my career. Working in a small company, there weren't really incentives for us to automate testing and we were not following any kind of best practices. Our way of working was to write the code, test it manually and then just Release It ™ , preferably on a Friday of course. I'm sure everyone can relate to this at some point in their career, because this is a lot more common than the Almighty Programming Gods of the Internet make us believe. I find that the amount of companies that actually bother writing tests for their production code is a fraction of the whole universe. I know some friends who work in pretty big companies with big names in the industry and even there the same mindset exists. Of course, at some point in time our code turned into a big pile of shit . Nobody really knew what was going on and where. We had quantum-level switcheroo that nobody really wanted to touch, and I suspect it i...

From crappy to happy - dependency what, now?

Following the introduction on this series on a previous post, we will now talk about dependency injection and how it has the effect of allowing for more testable code. Sometimes when I talk about this concept it is difficult to explain the effect that applying it might have on the tests. For that reason I think it is better to demonstrate with a near-real-world situation. Obviously, keep in mind this is not real code, so don't worry about the design or implementation details that don't contribute to the point being discussed. The code As you can see, it is simple. There's a class called ShipManager (what else?) that receives position updates for the ships. It keeps the last position reported from each ship and does some calculation to see how much the ship moved. It assigns some values to the update and finally it persists the final version of the update. How do we start testing? When you think about it, tests are dead simple. A test either passes or it doesn...

Left fold

Search This Blog